Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): allow non-empty directories to be initialized #51

Merged
merged 3 commits into from
Jan 23, 2024
Merged

feat(cli): allow non-empty directories to be initialized #51

merged 3 commits into from
Jan 23, 2024

Conversation

Simoon-F
Copy link
Member

@Simoon-F Simoon-F commented Jan 20, 2024 •
edited
Loading

🤔 What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

🔗 Related issue link

#50
#52

🚀 Summary

@Simoon-F Simoon-F added the enhancement New feature or request label Jan 20, 2024
@Simoon-F Simoon-F requested a review from goodjun January 20, 2024 03:44
@Simoon-F Simoon-F self-assigned this Jan 20, 2024
@Simoon-F Simoon-F linked an issue Jan 20, 2024 that may be closed by this pull request
TODO: Allow non-empty directories to be initialized #50
Closed
@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Simoon-F Simoon-F linked an issue Jan 22, 2024 that may be closed by this pull request
Miss devDependencies '@types/node' #52
Closed
@Simoon-F Simoon-F added the bug Something isn't working label Jan 22, 2024
goodjun
goodjun approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@goodjun goodjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goodjun goodjun merged commit 9928658 into main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodjun goodjun goodjun approved these changes

Assignees

@Simoon-F Simoon-F

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Miss devDependencies '@types/node' TODO: Allow non-empty directories to be initialized
2 participants
@Simoon-F @goodjun